Merge PR #425: feat(#417): add pokemon-player skill

Authored by teyrebaz33. Closes #417.
Adds pokemon-player skill for playing Pokemon via headless emulation
using the pokemon-agent package (NousResearch/pokemon-agent).

cli.py

@@ -725,7 +725,6 @@ HERMES_CADUCEUS = """[#CD7F32]⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣀⡀⠀⣀⣀
 [#B8860B]⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀[/]"""
 
 # Compact banner for smaller terminals (fallback)
-# Note: built dynamically by _build_compact_banner() to fit terminal width
 COMPACT_BANNER = """
 [bold #FFD700]╔══════════════════════════════════════════════════════════════╗[/]
 [bold #FFD700]║[/]  [#FFBF00]⚕ NOUS HERMES[/] [dim #B8860B]- AI Agent Framework[/]              [bold #FFD700]║[/]
@@ -734,26 +733,6 @@ COMPACT_BANNER = """
 """
 
 
-def _build_compact_banner() -> str:
-    """Build a compact banner that fits the current terminal width."""
-    w = min(shutil.get_terminal_size().columns - 2, 64)
-    if w < 30:
-        return "\n[#FFBF00]⚕ NOUS HERMES[/] [dim #B8860B]- Nous Research[/]\n"
-    inner = w - 2  # inside the box border
-    bar = "═" * w
-    line1 = "⚕ NOUS HERMES - AI Agent Framework"
-    line2 = "Messenger of the Digital Gods  ·  Nous Research"
-    # Truncate and pad to fit
-    line1 = line1[:inner - 2].ljust(inner - 2)
-    line2 = line2[:inner - 2].ljust(inner - 2)
-    return (
-        f"\n[bold #FFD700]╔{bar}╗[/]\n"
-        f"[bold #FFD700]║[/] [#FFBF00]{line1}[/] [bold #FFD700]║[/]\n"
-        f"[bold #FFD700]║[/] [dim #B8860B]{line2}[/] [bold #FFD700]║[/]\n"
-        f"[bold #FFD700]╚{bar}╝[/]\n"
-    )
-
-
 def _get_available_skills() -> Dict[str, List[str]]:
     """
     Scan ~/.hermes/skills/ and return skills grouped by category.
@@ -951,12 +930,10 @@ def build_welcome_banner(console: Console, model: str, cwd: str, tools: List[dic
         padding=(0, 2),
     )
     
-    # Print the big HERMES-AGENT logo — skip if terminal is too narrow
+    # Print the big HERMES-AGENT logo first (no panel wrapper for full width)
+    console.print()
+    console.print(HERMES_AGENT_LOGO)
     console.print()
-    term_width = shutil.get_terminal_size().columns
-    if term_width >= 95:
-        console.print(HERMES_AGENT_LOGO)
-        console.print()
     
     # Print the panel with caduceus and info
     console.print(outer_panel)
@@ -1406,13 +1383,8 @@ class HermesCLI:
         """Display the welcome banner in Claude Code style."""
         self.console.clear()
         
-        # Auto-compact for narrow terminals — the full banner with caduceus
-        # + tool list needs ~80 columns minimum to render without wrapping.
-        term_width = shutil.get_terminal_size().columns
-        use_compact = self.compact or term_width < 80
-        
-        if use_compact:
-            self.console.print(_build_compact_banner())
+        if self.compact:
+            self.console.print(COMPACT_BANNER)
             self._show_status()
         else:
             # Get tools for display
@@ -2422,9 +2394,8 @@ class HermesCLI:
             # and gets mangled by patch_stdout).
             if self._app:
                 cc = ChatConsole()
-                term_w = shutil.get_terminal_size().columns
-                if self.compact or term_w < 80:
-                    cc.print(_build_compact_banner())
+                if self.compact:
+                    cc.print(COMPACT_BANNER)
                 else:
                     tools = get_tool_definitions(enabled_toolsets=self.enabled_toolsets, quiet_mode=True)
                     cwd = os.getenv("TERMINAL_CWD", os.getcwd())

gateway/platforms/telegram.py

@@ -346,64 +346,6 @@ class TelegramAdapter(BasePlatformAdapter):
             print(f"[{self.name}] Failed to send local image: {e}")
             return await super().send_image_file(chat_id, image_path, caption, reply_to)
 
-    async def send_document(
-        self,
-        chat_id: str,
-        file_path: str,
-        caption: Optional[str] = None,
-        file_name: Optional[str] = None,
-        reply_to: Optional[str] = None,
-    ) -> SendResult:
-        """Send a document/file natively as a Telegram file attachment."""
-        if not self._bot:
-            return SendResult(success=False, error="Not connected")
-
-        try:
-            if not os.path.exists(file_path):
-                return SendResult(success=False, error=f"File not found: {file_path}")
-
-            display_name = file_name or os.path.basename(file_path)
-
-            with open(file_path, "rb") as f:
-                msg = await self._bot.send_document(
-                    chat_id=int(chat_id),
-                    document=f,
-                    filename=display_name,
-                    caption=caption[:1024] if caption else None,
-                    reply_to_message_id=int(reply_to) if reply_to else None,
-                )
-            return SendResult(success=True, message_id=str(msg.message_id))
-        except Exception as e:
-            print(f"[{self.name}] Failed to send document: {e}")
-            return await super().send_document(chat_id, file_path, caption, file_name, reply_to)
-
-    async def send_video(
-        self,
-        chat_id: str,
-        video_path: str,
-        caption: Optional[str] = None,
-        reply_to: Optional[str] = None,
-    ) -> SendResult:
-        """Send a video natively as a Telegram video message."""
-        if not self._bot:
-            return SendResult(success=False, error="Not connected")
-
-        try:
-            if not os.path.exists(video_path):
-                return SendResult(success=False, error=f"Video file not found: {video_path}")
-
-            with open(video_path, "rb") as f:
-                msg = await self._bot.send_video(
-                    chat_id=int(chat_id),
-                    video=f,
-                    caption=caption[:1024] if caption else None,
-                    reply_to_message_id=int(reply_to) if reply_to else None,
-                )
-            return SendResult(success=True, message_id=str(msg.message_id))
-        except Exception as e:
-            print(f"[{self.name}] Failed to send video: {e}")
-            return await super().send_video(chat_id, video_path, caption, reply_to)
-
     async def send_image(
         self,
         chat_id: str,

skills/gaming/pokemon-player/SKILL.md

@@ -0,0 +1,161 @@
+---
+name: pokemon-player
+description: Play Pokémon games autonomously via headless emulation. Starts a game server, reads structured game state from RAM, makes strategic decisions, and sends button inputs — all from the terminal.
+tags: [gaming, pokemon, emulator, pyboy, gameplay, gameboy]
+---
+# Pokémon Player
+
+Play Pokémon games via headless emulation using the `pokemon-agent` package.
+
+## When to Use
+- User says "play pokemon", "start pokemon", "pokemon game"
+- User asks about Pokemon Red, Blue, Yellow, FireRed, etc.
+- User wants to watch an AI play Pokemon
+- User references a ROM file (.gb, .gbc, .gba)
+
+## First-Time Setup
+
+### 1. Install the package
+```bash
+pip install pokemon-agent[dashboard] pyboy
+```
+
+### 2. Get the ROM
+Ask the user for their ROM file path. Do NOT attempt to download ROMs.
+
+### 3. Start the game server
+```bash
+pokemon-agent serve --rom <ROM_PATH> --port 8765 &
+```
+Wait 3 seconds, then verify:
+```bash
+curl -s http://localhost:8765/health
+```
+
+## The Gameplay Loop
+
+### Step 1: OBSERVE
+```bash
+curl -s http://localhost:8765/state
+```
+
+### Step 2: ORIENT
+- Dialog active → advance text
+- In battle → fight
+- Party hurt → heal
+- Near objective → navigate
+
+### Step 3: DECIDE
+Priority order:
+1. If dialog active → a_until_dialog_end
+2. If in battle → choose best move
+3. If any Pokemon <20% HP → Pokémon Center
+4. If near story objective → navigate to it
+5. If underleveled → train in grass
+6. Otherwise → explore
+
+### Step 4: ACT
+```bash
+curl -s -X POST http://localhost:8765/action \
+  -H "Content-Type: application/json" \
+  -d '{"actions": ["walk_up", "walk_up", "press_a"]}'
+```
+
+Action reference:
+- press_a — confirm, talk, select
+- press_b — cancel, close menu
+- press_start — open game menu
+- walk_up/down/left/right — move one tile
+- a_until_dialog_end — advance all dialog
+- wait_60 — wait ~1 second
+
+### Step 5: VERIFY
+Check state_after in the response. If stuck 3+ turns:
+1. Press B several times
+2. Try different directions
+3. Take screenshot and use vision_analyze
+4. Load last save if truly stuck
+
+### Step 6: RECORD
+```
+memory add: PKM:OBJECTIVE: Heading to Pewter City to challenge Brock
+memory add: PKM:PROGRESS: Got Squirtle, Got Pokedex, → Pewter City
+```
+
+### Step 7: SAVE
+Save every 20-30 turns and ALWAYS before gym battles:
+```bash
+curl -s -X POST http://localhost:8765/save \
+  -H "Content-Type: application/json" \
+  -d '{"name": "before_brock"}'
+```
+
+## Battle Strategy
+
+### Decision Tree
+1. Want to catch? → Weaken then throw Poké Ball
+2. Wild you don't need? → RUN
+3. Type advantage? → Use super-effective move
+4. No advantage? → Use strongest STAB move
+5. Low HP? → Switch or use Potion
+
+### Type Chart
+- Water beats Fire, Ground, Rock
+- Fire beats Grass, Bug, Ice
+- Grass beats Water, Ground, Rock
+- Electric beats Water, Flying
+- Ground beats Fire, Electric, Rock, Poison
+- Psychic beats Fighting, Poison (dominant in Gen 1!)
+
+### Gen 1 Quirks
+- Special stat is both offense AND defense for special moves
+- Psychic is overpowered (Ghost moves bugged)
+- Critical hits based on Speed stat
+- Wrap/Bind prevent opponent from acting
+
+## Memory Conventions
+| Prefix | Purpose | Example |
+|--------|---------|---------|
+| PKM:OBJECTIVE | Current goal | Defeat Brock in Pewter City |
+| PKM:MAP | Navigation knowledge | Viridian Forest: go north |
+| PKM:STRATEGY | Battle/team plans | Need Grass type before Misty |
+| PKM:PROGRESS | Milestone tracker | ✓ Boulder Badge → Cascade Badge |
+| PKM:STUCK | Stuck situations | Got stuck in Cerulean Cave |
+| PKM:TEAM | Team notes | Squirtle is Water/Ice coverage |
+
+## Progression Milestones
+- ☐ Choose starter
+- ☐ Deliver Oak's Parcel → receive Pokédex
+- ☐ Boulder Badge — Brock (Rock) → use Water/Grass
+- ☐ Cascade Badge — Misty (Water) → use Grass/Electric
+- ☐ Thunder Badge — Lt. Surge (Electric) → use Ground
+- ☐ Rainbow Badge — Erika (Grass) → use Fire/Ice/Flying
+- ☐ Soul Badge — Koga (Poison) → use Ground/Psychic
+- ☐ Marsh Badge — Sabrina (Psychic)
+- ☐ Volcano Badge — Blaine (Fire) → use Water/Ground
+- ☐ Earth Badge — Giovanni (Ground) → use Water/Grass/Ice
+- ☐ Elite Four → Champion!
+
+## Stopping Play
+1. Save the game:
+```bash
+curl -s -X POST http://localhost:8765/save \
+  -d '{"name": "session_end"}'
+```
+2. Update memory with progress
+3. Tell user: "Game saved! Say 'play pokemon' to resume."
+4. Kill the background server process
+
+## Dashboard
+If `pokemon-agent[dashboard]` is installed, open:
+http://localhost:8765/dashboard
+
+Live features: game screen, AI reasoning stream, team status, action log.
+
+## Pitfalls
+- NEVER download or provide ROM files — always ask the user
+- Don't send more than 15 actions per /action call
+- Always wait for dialog to clear before moving
+- Save BEFORE gym battles
+- Take screenshots sparingly — they cost vision tokens
+- Verify server is running with /health before any commands

tests/gateway/test_telegram_documents.py

@@ -20,7 +20,6 @@ from gateway.config import Platform, PlatformConfig
 from gateway.platforms.base import (
     MessageEvent,
     MessageType,
-    SendResult,
     SUPPORTED_DOCUMENT_TYPES,
 )
 
@@ -337,203 +336,3 @@ class TestDocumentDownloadBlock:
         await adapter._handle_media_message(update, MagicMock())
         # handle_message should still be called (the handler catches the exception)
         adapter.handle_message.assert_called_once()
-
-
-# ---------------------------------------------------------------------------
-# TestSendDocument — outbound file attachment delivery
-# ---------------------------------------------------------------------------
-
-class TestSendDocument:
-    """Tests for TelegramAdapter.send_document() — sending files to users."""
-
-    @pytest.fixture()
-    def connected_adapter(self, adapter):
-        """Adapter with a mock bot attached."""
-        bot = AsyncMock()
-        adapter._bot = bot
-        return adapter
-
-    @pytest.mark.asyncio
-    async def test_send_document_success(self, connected_adapter, tmp_path):
-        """A local file is sent via bot.send_document and returns success."""
-        # Create a real temp file
-        test_file = tmp_path / "report.pdf"
-        test_file.write_bytes(b"%PDF-1.4 fake content")
-
-        mock_msg = MagicMock()
-        mock_msg.message_id = 99
-        connected_adapter._bot.send_document = AsyncMock(return_value=mock_msg)
-
-        result = await connected_adapter.send_document(
-            chat_id="12345",
-            file_path=str(test_file),
-            caption="Here's the report",
-        )
-
-        assert result.success is True
-        assert result.message_id == "99"
-        connected_adapter._bot.send_document.assert_called_once()
-        call_kwargs = connected_adapter._bot.send_document.call_args[1]
-        assert call_kwargs["chat_id"] == 12345
-        assert call_kwargs["filename"] == "report.pdf"
-        assert call_kwargs["caption"] == "Here's the report"
-
-    @pytest.mark.asyncio
-    async def test_send_document_custom_filename(self, connected_adapter, tmp_path):
-        """The file_name parameter overrides the basename for display."""
-        test_file = tmp_path / "doc_abc123_ugly.csv"
-        test_file.write_bytes(b"a,b,c\n1,2,3")
-
-        mock_msg = MagicMock()
-        mock_msg.message_id = 100
-        connected_adapter._bot.send_document = AsyncMock(return_value=mock_msg)
-
-        result = await connected_adapter.send_document(
-            chat_id="12345",
-            file_path=str(test_file),
-            file_name="clean_data.csv",
-        )
-
-        assert result.success is True
-        call_kwargs = connected_adapter._bot.send_document.call_args[1]
-        assert call_kwargs["filename"] == "clean_data.csv"
-
-    @pytest.mark.asyncio
-    async def test_send_document_file_not_found(self, connected_adapter):
-        """Missing file returns error without calling Telegram API."""
-        result = await connected_adapter.send_document(
-            chat_id="12345",
-            file_path="/nonexistent/file.pdf",
-        )
-
-        assert result.success is False
-        assert "not found" in result.error.lower()
-        connected_adapter._bot.send_document.assert_not_called()
-
-    @pytest.mark.asyncio
-    async def test_send_document_not_connected(self, adapter):
-        """If bot is None, returns not connected error."""
-        result = await adapter.send_document(
-            chat_id="12345",
-            file_path="/some/file.pdf",
-        )
-
-        assert result.success is False
-        assert "Not connected" in result.error
-
-    @pytest.mark.asyncio
-    async def test_send_document_caption_truncated(self, connected_adapter, tmp_path):
-        """Captions longer than 1024 chars are truncated."""
-        test_file = tmp_path / "data.json"
-        test_file.write_bytes(b"{}")
-
-        mock_msg = MagicMock()
-        mock_msg.message_id = 101
-        connected_adapter._bot.send_document = AsyncMock(return_value=mock_msg)
-
-        long_caption = "x" * 2000
-        await connected_adapter.send_document(
-            chat_id="12345",
-            file_path=str(test_file),
-            caption=long_caption,
-        )
-
-        call_kwargs = connected_adapter._bot.send_document.call_args[1]
-        assert len(call_kwargs["caption"]) == 1024
-
-    @pytest.mark.asyncio
-    async def test_send_document_api_error_falls_back(self, connected_adapter, tmp_path):
-        """If Telegram API raises, falls back to base class text message."""
-        test_file = tmp_path / "file.pdf"
-        test_file.write_bytes(b"data")
-
-        connected_adapter._bot.send_document = AsyncMock(
-            side_effect=RuntimeError("Telegram API error")
-        )
-
-        # The base fallback calls self.send() which is also on _bot, so mock it
-        # to avoid cascading errors.
-        connected_adapter.send = AsyncMock(
-            return_value=SendResult(success=True, message_id="fallback")
-        )
-
-        result = await connected_adapter.send_document(
-            chat_id="12345",
-            file_path=str(test_file),
-        )
-
-        # Should have fallen back to base class
-        assert result.success is True
-        assert result.message_id == "fallback"
-
-    @pytest.mark.asyncio
-    async def test_send_document_reply_to(self, connected_adapter, tmp_path):
-        """reply_to parameter is forwarded as reply_to_message_id."""
-        test_file = tmp_path / "spec.md"
-        test_file.write_bytes(b"# Spec")
-
-        mock_msg = MagicMock()
-        mock_msg.message_id = 102
-        connected_adapter._bot.send_document = AsyncMock(return_value=mock_msg)
-
-        await connected_adapter.send_document(
-            chat_id="12345",
-            file_path=str(test_file),
-            reply_to="50",
-        )
-
-        call_kwargs = connected_adapter._bot.send_document.call_args[1]
-        assert call_kwargs["reply_to_message_id"] == 50
-
-
-# ---------------------------------------------------------------------------
-# TestSendVideo — outbound video delivery
-# ---------------------------------------------------------------------------
-
-class TestSendVideo:
-    """Tests for TelegramAdapter.send_video() — sending videos to users."""
-
-    @pytest.fixture()
-    def connected_adapter(self, adapter):
-        bot = AsyncMock()
-        adapter._bot = bot
-        return adapter
-
-    @pytest.mark.asyncio
-    async def test_send_video_success(self, connected_adapter, tmp_path):
-        test_file = tmp_path / "clip.mp4"
-        test_file.write_bytes(b"\x00\x00\x00\x1c" + b"ftyp" + b"\x00" * 100)
-
-        mock_msg = MagicMock()
-        mock_msg.message_id = 200
-        connected_adapter._bot.send_video = AsyncMock(return_value=mock_msg)
-
-        result = await connected_adapter.send_video(
-            chat_id="12345",
-            video_path=str(test_file),
-            caption="Check this out",
-        )
-
-        assert result.success is True
-        assert result.message_id == "200"
-        connected_adapter._bot.send_video.assert_called_once()
-
-    @pytest.mark.asyncio
-    async def test_send_video_file_not_found(self, connected_adapter):
-        result = await connected_adapter.send_video(
-            chat_id="12345",
-            video_path="/nonexistent/video.mp4",
-        )
-
-        assert result.success is False
-        assert "not found" in result.error.lower()
-
-    @pytest.mark.asyncio
-    async def test_send_video_not_connected(self, adapter):
-        result = await adapter.send_video(
-            chat_id="12345",
-            video_path="/some/video.mp4",
-        )
-
-        assert result.success is False
-        assert "Not connected" in result.error